HomePhabricator

Swapped byte detection in Multi Channel Encapsulation.
4a2c04f74e76Unpublished

Authored by Jan-Willem Spuij <jws@birdseyeview.nl> on Mar 18 2016, 12:13 PM.

Unpublished Commit ยท Learn More

  • Repository Importing: This repository is still importing.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Swapped byte detection in Multi Channel Encapsulation.

This code detects swapped bytes in Multi Channel Encapsulation messages
sent to the controller. The controller has no endpoints and therefore
should always be addressed as 1, while originating can be between 1 and

  1. When destination != 1 for the controller, the packet is invalid.

The greenwave nodes make this mistake in their firmware.

Fixes #738.

Signed-off-by: Jan-Willem Spuij jw@spuij.nl (github: jspuij)

Details

Event Timeline